Move from libsass -> dart-sass #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
added a commit
to alphagov/govuk-docker
that referenced
this pull request
Jan 22, 2024
When I moved [1] the support app from libsass to dart-sass following these instructions [2], I created a new `bin/dev` file which runs two processes in `procfile.dev`, one of which runs the rails server on port 3070 instead of port 3000. This updates the `docker-compose.yml` file accordingly. [1]: alphagov/support#1253 [2]: https://docs.publishing.service.gov.uk/manual/migrate-to-dart-sass-from-libsass.html
floehopper
force-pushed
the
move-from-libsass-to-dart-sass
branch
3 times, most recently
from
0846912 to
39500a2
Compare
floehopper
requested review from
chrisroos,
chrislo,
MuriloDalRi and
AgaDufrat
chrisroos
reviewed
Jan 22, 2024
floehopper
added a commit
to alphagov/govuk-docker
that referenced
this pull request
Jan 22, 2024
When I moved [1] the support app from libsass to dart-sass following these instructions [2], I created a new `bin/dev` file which runs two processes in `Procfile.dev`, one of which runs the rails server and another which runs `dart-sass` in watch mode. This updates the `docker-compose.yml` file accordingly. [1]: alphagov/support#1253 [2]: https://docs.publishing.service.gov.uk/manual/migrate-to-dart-sass-from-libsass.html
I followed these instructions [1]. I'm hoping that this will fix a `SassC::SyntaxError` that I'm seeing after adding `govuk_publishing_components` when running `RAILS_ENV=production rails assets:precompile`. Note that running `bundle install` has removed the `ruby` platform. We think this is because `sass-embedded`, a dependency of `dartsass-rails`, doesn't have a non-platform-specific variant of the gem and so bundler can no longer support the `ruby` platform. [1]: https://docs.publishing.service.gov.uk/manual/migrate-to-dart-sass-from-libsass.html
floehopper
force-pushed
the
move-from-libsass-to-dart-sass
branch
from
39500a2 to
610e25a
Compare
I have now rebased the branch in this draft PR against this branch and confirmed that it does indeed fix the |
AgaDufrat
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LibSass is now deprecated, this is a change that needs making anyway. However, my actual motivation is that
I'm hoping it will fixit fixes aSassC::SyntaxErrorthat I'm seeing after addinggovuk_publishing_componentswhen runningRAILS_ENV=production rails assets:precompilein order to start moving the app to use the GOV.UK Design System. See this build failure which occurred against the code in this draft PR.I followed these instructions in the GOV.UK Developer Docs to make the change. Once it's merged, there's also a corresponding change to govuk-docker that will need to me made - see this PR.
I've tested this locally using the modified version of
govuk-dockerand verified that I can make changes to CSS and see them reflected in the rendered pages. I've also runRAILS_ENV=production rails assets:precompilelocally and I don't see any errors or warnings. However, note that the instructions told me to suppress warnings in dependencies and before I did that, I did see some deprecation warnings before I did that which doesn't seem ideal.