Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link text in banners to be more accessible #929

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

selfthinker
Copy link
Contributor

When reading out of context, for example when using a screen reader, "find out what this means" is not very clear.

When reading out of context, for example when using a screen reader,
"find out what this means" is not very clear.
@edwardhorsford
Copy link

I'm not convinced this is an improvement.

It's introducing language (alpha) that people are unlikely to know. It makes the link more specific, but also more complex. Would like a content designer to review.

@selfthinker
Copy link
Contributor Author

It doesn't introduce anything new, it already says "alpha" and the word "this" is exactly what is meant there.
Initially the whole sentence read:

Alpha This part of GOV.UK is being built - (link)find out what this means(/link)

@NickColley
Copy link
Contributor

NickColley commented Mar 8, 2017

This looks good to me 👍 I've pinged to the content team...

@selfthinker
Copy link
Contributor Author

I wasn't sure if there will still be feedback from the content team. But as there doesn't seem to be any, I will merge now.

@selfthinker selfthinker merged commit 33c210a into master Mar 17, 2017
@NickColley NickColley deleted the accessible-banner-links branch March 20, 2017 11:03
@NickColley
Copy link
Contributor

Thanks @selfthinker :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants