Remove external link icons #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps govuk_frontend_toolkit and govuk_template to the latest versions (removing the external link icons and code), and removes references to external links from the stylesheets in static. It also fixes the spelling of accordian to accordion. The one non-trivial change is the removal of display:inline from external links in info-notice. This was added in 2a6a299 , but I can’t find any reason for it to still be there: there aren’t any bases styles this is overriding any more.
|
Fixes #845 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps govuk_frontend_toolkit and govuk_template to the latest versions (removing the external link icons and code), and removes references to external links from the stylesheets in static.
It also fixes the spelling of accordian to accordion.
The one non-trivial change is the removal of
display:inlinefrom external links ininfo-notice. This was added in 2a6a299 , but I can’t find any reason for it to still be there: there aren’t any bases styles this is overriding any more.