Add activeWhen callback for small surveys and use for 9th/10th of August #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalleth
changed the title
kalleth
force-pushed
the
add-activewhen-callback-for-smallsurveys
branch
2 times, most recently
from
99ceb4a to
9af2f57
Compare
| activeWhen: function() { | ||
| function breadcrumbMatches() { | ||
| var text = $('#global-breadcrumb').text() || ""; | ||
| return (/Education and learning/.test(text) || /Schools and education/.test(text)); |
There was a problem hiding this comment.
Im not wild about this mechanism of detecting "education content". I'm going to push back and see if the logic below in sectionMatches() will match enough to make this a worthwhile test.
OTOH, this specific callback is only temporary and will be removed in a couple of weeks after the test has run.
kalleth
force-pushed
the
add-activewhen-callback-for-smallsurveys
branch
3 times, most recently
from
0acd961 to
19f4e69
Compare
| function organisationMatches() { | ||
| var orgMatchingExpr = /<D6>|<D106>|<D109>|<EA243>|<EA86>|<EA242>|<EA541>/; | ||
| var metaText = $('meta[name="govuk:analytics:organisations"]').attr('content') || ""; | ||
| return orgMatchingExpr.test(metaText); |
There was a problem hiding this comment.
This will return false (and not error) when the meta tag is not present on the page.
kalleth
changed the title
| return orgMatchingExpr.test(metaText); | ||
| } | ||
|
|
||
| return (sectionMatches() || breadcrumbMatches() || organisationMatches()); |
There was a problem hiding this comment.
Like the readability here
|
Well done for finding a path through the taxonomy detection. LGTM |
This allows surveys to take place only on certain pages. Now the survey code has reached this level of complexity, let's provide some documentation on it (in `doc/surveys.md`) so people can read about what we support.
kalleth
force-pushed
the
add-activewhen-callback-for-smallsurveys
branch
from
19f4e69 to
093d361
Compare
The same content as the main survey, but shown 5x more frequently on
education content.
This survey is only active when:
* The breadcrumb contains 'Education' OR 'Schools' OR 'Childcare',
case insensitive.
* The `govuk:section` metatag equals "education and learning" OR
"childcare and parenting" -- i.e. the content is given this section
in panopticon.
* The `govuk:analytics:organisations` tag contains one of
`<D6>|<D106>|<D109>|<EA243>|<EA86>|<EA242>|<EA541>`, meaning the
organisation is DfE, Ofsted, Ofqual, STA, SFA, EFA, or NCTL.
kalleth
force-pushed
the
add-activewhen-callback-for-smallsurveys
branch
from
093d361 to
de312ee
Compare
|
I've done some checks locally on static and this has passed PR review. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Please review commit by commit.
Adding
activeWhencallbackThis allows surveys to take place only on certain pages, superseding the default survey.
Now the survey code has reached this level of complexity, let's provide some documentation on it (in
doc/surveys.md) so people can read about what we support.Remove survey that has now completed
ronseal
Add new small survey to run 9th/10th of August
See commit message for reasoning.