Add translations for all govuk components #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved locales back into conventional place to help people in the future find them where they'd expect
| @@ -24,14 +24,15 @@ def govuk_component_docs | |||
| end | |||
|
|
|||
| def govuk_available_locales | |||
| locale_files = Rails.root.join('app', 'views', 'locales', '*.yml') | |||
| locale_files = Rails.root.join("config", "locales", "*.yml") | |||
| locales = Dir[locale_files].map { |file| File.basename(file, '.yml') } | |||
| render :json => locales | |||
| end | |||
|
|
|||
| def govuk_locales | |||
| return error_404 unless params[:locale].match(/^[a-z]{2}(-[a-z0-9]{2,3})?$/) | |||
There was a problem hiding this comment.
That regular expression will allow something like pt-p1p, which ISO-639 are we using and which ISO is that regex trying to accommodate?
There was a problem hiding this comment.
I'm not familiar with the internals of the i18n for Rails so not sure, this seems like a sanity check but maybe something like https://github.com/tigrish/iso#tags would be more appropriate.
There was a problem hiding this comment.
There is a bit of a mixture of ISO-639 standards and one or two non-standard locales. I think this is reasonable as a simple check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work done in #505
Moves the language translation config files back into the conventional place rather than in the view directory.