Add HMRC webchat to ‘manage your tax credits’ page #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request from HMRC
|
👍 |
|
This looks like what we did the last time we had to add it to a page, so 👍. |
| @@ -25,6 +25,7 @@ | |||
| '/vat-registration/changes-to-your-details', | |||
| '/government/organisations/hm-revenue-customs/contact/national-insurance-numbers', | |||
| '/lost-national-insurance-number', | |||
| '/manage-your-tax-credits', | |||
There was a problem hiding this comment.
Trailing comma will break in IE7+8. Can it be removed?
There was a problem hiding this comment.
We tend to keep trailing commas around to reduce noisy diffs when the next change comes (otherwise you'd have two lines changed because of adding a comma to the previous line) but yeah, if it breaks something... 👍
There was a problem hiding this comment.
JavaScript is the exception to this rule. Trailing commas break older IEs and are hard to track down.
It would probably break IE
|
FTFY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from HMRC
To be merged and deployed on Friday 20 May 2016.