Correcting header typo on scroll-tracking.js #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting typo on heading 'When you can claim Universal Credit' on /guidance/universal-credit-how-it-helps-you-into-work which prevented the scroll event from firing
|
I wonder if in the future, it would be worth adding the links into the PR description, so we can click through and verify the target page exist, and that the headings exist. For example:
Even though it doesn't verify the heading text is matching, it will make it easier for the reviewer of the PR to go to the target page and check |
|
Yep good idea, will do from now on |
erkde
pushed a commit
that referenced
this pull request
Feb 29, 2016
Correcting header typo on scroll-tracking.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting typo on heading 'When you can claim Universal Credit' on /guidance/universal-credit-how-it-helps-you-into-work which prevented the scroll event from firing.