Fix alignment of report-a-problem at certain widths #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At a breakpoint below 1020 the report a problem link, and form, weren't aligned to the grid of the rest of the page, and were indented by an additional 30px on each side. This was caused by `%site-width-container` being used on the report a problem containers, within `#wrapper`, which already extends `%site-width-container`, causing double margins. As the report a problem elements already inside a page width container it's same to remove the use of `%site-width-container` for them.
|
👍 |
fofr
added a commit
that referenced
this pull request
Oct 9, 2015
Fix alignment of report-a-problem at certain widths
dsingleton
added a commit
that referenced
this pull request
Oct 12, 2015
…nt-fix Revert "Merge pull request #660 from alphagov/fix-report-a-problem-alignment"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a breakpoint below 1020 the report a problem link, and form, weren't aligned to the grid of the rest of the page, and were indented by an additional 30px on each side.
This was caused by
%site-width-containerbeing used on the report a problem containers, within#wrapper, which already extends%site-width-container, causing double margins.As the report a problem elements already inside a page width container it's same to remove the use of
%site-width-containerfor them.