Add cross domain tracking #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the cross domain tracking functionality.
| @@ -111,6 +111,10 @@ | |||
| this.tracker.trackShare(network); | |||
| }; | |||
|
|
|||
| StaticTracker.prototype.addLinkedDomain = function(trackerId, name, domain) { | |||
There was a problem hiding this comment.
Should this be addLinkedTrackerDomain? (Though I prefer addLinkedDomain)
There was a problem hiding this comment.
On the fence about that, I thought I'd make the public method shorter. Will update for parity.
There was a problem hiding this comment.
Updated and force pushed.
|
One minor comment, otherwise this and alphagov/business-support-finder#87 look good. |
bradwright
force-pushed
the
add-cross-domain-tracking
branch
from
d0797f0 to
be6beae
Compare
|
Updated this and alphagov/business-support-finder#87 to match the public API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the cross domain tracking functionality from alphagov/govuk_frontend_toolkit#185 to static, making it globally available.