Update libv8 to fix error on bundle install on OS X Yosemite #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was seeing the following error when running `bundle install`:
Unable to find a compiler officially supported by v8.
It is recommended to use GCC v4.4 or higher
Using compiler: g++
This then seems to have resulted in the following compilation error:
../src/cached-powers.cc:136:18: error: unused variable 'kCachedPowersLength' [-Werror,-Wunused-const-variable]
static const int kCachedPowersLength = ARRAY_SIZE(kCachedPowers);
^
I believe the problem was fixed [1] between version 3.16.14.3 and version
3.16.14.7 of libv8 and a simple `bundle update libv8` seems to have done the
trick.
[1]: rubyjs/libv8#124
floehopper
added a commit
to freerange/imminence
that referenced
this pull request
Apr 13, 2015
I was seeing the following error when running `bundle install`:
Unable to find a compiler officially supported by v8.
It is recommended to use GCC v4.4 or higher
Using compiler: g++
This then seems to have resulted in the following compilation error:
../src/cached-powers.cc:136:18: error: unused variable 'kCachedPowersLength' [-Werror,-Wunused-const-variable]
static const int kCachedPowersLength = ARRAY_SIZE(kCachedPowers);
^
I believe the problem was fixed [1] between version 3.16.14.3 and version
3.16.14.7 of `libv8`. Relaxing the Gemfile constraint on `therubyracer` and
bundle updating `therubyracer` & `libv8` seems to have done the trick.
See also a similar fix for the `static` app [2].
[1]: rubyjs/libv8#124
[2]: alphagov/static#570
benilovj
added a commit
that referenced
this pull request
Apr 20, 2015
Update libv8 to fix error on bundle install on OS X Yosemite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing the following error when running
bundle install:This then seems to have resulted in the following compilation error:
I believe the problem was fixed between version 3.16.14.3 and version
3.16.14.7 of libv8 and a simple
bundle update libv8seems to have done thetrick.