Use SelectionButtons live selector, for JS/AJAX content #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some GOV.UK pages, like Smart Answers, load content via JS, including radio buttons or checkboxes. These will be added to the DOM after the selector is run and the resulting elements are passed to SelectionButtons SelectionButtons can also take a string selector and use document events (alphagov/govuk_frontend_toolkit#139) so use that and any JS loaded content will get the behaviour too.
alicebartlett
added a commit
that referenced
this pull request
Jan 26, 2015
Use SelectionButtons live selector, for JS/AJAX content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GOV.UK pages, like Smart Answers, load content via JS, including
radio buttons or checkboxes. These will be added to the DOM after the
selector is run and the resulting elements are passed to SelectionButtons
SelectionButtons can also take a string selector and use document
events (alphagov/govuk_frontend_toolkit#139)
so use that and any JS loaded content will get the behaviour too.
@robmckinnon spotted this in alphagov/smart-answers#1419, but it's better to fix it in the app we're applying it (otherwise we'll run into versioning problems eventually)