Remove old analytics JavaScript #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This analytics was added for the performance platform to create an engagement score of pages. They have since stopped using these events and they are no longer needed. Remove them so they stop sending lots of events to Google Analytics. Tidy up the function in `tracking.js` which is still needed so that it is clearer as to what is going on.
|
So much 🔴 |
|
This is brilliant, thanks @edds. We'll provide 🍰 at some point. |
bradwright
added a commit
that referenced
this pull request
Jan 8, 2015
Remove old analytics JavaScript
fofr
added a commit
to alphagov/slimmer
that referenced
this pull request
Mar 3, 2015
These variables were added to test guide success tracking in: #5 That success tracking was removed in: alphagov/static#522 They are no longer used and the “Analytics” namespace is being removed.
fofr
added a commit
to alphagov/slimmer
that referenced
this pull request
Mar 3, 2015
These variables were added to test guide success tracking in: #5 That success tracking was removed in: alphagov/static#522 They are no longer used and the “Analytics” namespace is being removed.
I've opened a ticket to do that because the expiration date for those cookies has passed. |
|
❤️ 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This analytics was added for the performance platform to create an
engagement score of pages. They have since stopped using these events
and they are no longer needed. Remove them so they stop sending lots of
events to Google Analytics.
Tidy up the function in
tracking.jswhich is still needed so that itis clearer as to what is going on.
This should enable us to remove GDS_successEvents and GDS_analyticsTokens from the cookie page as there will no longer be any code setting or getting those cookies.