Make application CSS/JS extend header_footer_only CSS/JS #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the CSS/JS modules included in the application 'layout' are also included in header_footer_only - and only those modules - so this makes application share exactly those modules by importing header footer only. This helps avoid bugs like #458 Also by treating each layout as an extension of an existing layout, layering new features on top, then we can easily add new kinds of layout in the future.
|
👍 |
dsingleton
added a commit
that referenced
this pull request
Sep 18, 2014
Make application CSS/JS extend header_footer_only CSS/JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the CSS/JS modules included in the application 'layout' are
also included in header_footer_only - and only those modules - so
this makes application share exactly those modules by importing
header footer only.
This helps avoid bugs like #458
Also by treating each layout as an extension of an existing layout,
layering new features on top, then we can easily add new kinds
of layout in the future.