Fix style-lint breaking change in static #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to prevent errors when linting single colon style pseudo class selectors. These need to be changed to double colons.
matthillco
changed the title
maxgds
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependabot automated dependency checker has recently reported style-lint errors in some SCSS across multiple repos, after the GDS stylelint module was updated from 0.3.0 to 1.0.0.
Some of these errors involve a change to how we should write pseudo element selectors: previously we've used single colons, eg
element:before, now we need to use the double colon syntax:element::before.This PR updates print styles in static to use the double colon syntax.
Trello