Use GA4 init code #2868
Merged
Use GA4 init code #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
ga4-consent
branch
from
e022a69 to
779459a
Compare
andysellick
force-pushed
the
ga4-consent
branch
from
779459a to
4e06429
Compare
JamesCGDS
dismissed
their stale review
Additional changes are being made beyond what was originally reviewed
- runs the new GA4 init code, which starts the analytics code only after cookie consent - note that this will not run anywhere but integration because the code it refers to is only included on integration - remove test that checked for the existing of the Google Tag Manager component, as we're not using it anymore
andysellick
force-pushed
the
ga4-consent
branch
from
4e06429 to
1c5f5c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This will depend on a new version of the components gem that includes alphagov/govuk_publishing_components#2915, until then this will silently do nothing. See that PR for details of how this works.
Why
Part of the process to move away from using the GTM component and integrating all of the new analytics code properly into the cookie consent mechanism.
Visual changes
None.
Trello card: https://trello.com/c/vrMj18et/353-integrate-gtm-with-cookie-consent-mechanism