Re-apply use of jasmine-browser-runner (re-reverts #2771) #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests would randomly fail because there was a run order failure. Setting all tests to accept cookie compliance, and then resetting after, fixes this issue.
chao-xian
changed the title
gclssvglx
approved these changes
May 24, 2022
There was a problem hiding this comment.
Fantastic work! Making the cookie state consistent between tests definitely seems to have resolved the failing test issue. Nice one @chao-xian 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applies #2763 plus a fix to the specs that had a run order bug.
(Reverts #2771 which itself is a revert of #2763 )
Description from original PR:
Migrating from jasmine gem which is deprecated and no supported in Rails 7.
This is a blocker to a Rails 7 upgrade
Trello