Add support for "Manage your account" active in the account nav #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
changed the title
When the account layout template renders with a nav, the "Your account" nav option is selected by default. Some pages which use the account layout belong under "Manage your account" instead of "Your account". This allows us the option to render the account layout with "Manage your account" selected/active in the account nav, instead of the default "Your account".
danacotoran
force-pushed
the
account-template-manage-account-active
branch
from
9d0512c to
3e5bfce
Compare
alex9smith
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the account layout template renders with a nav, the "Your account" nav option is selected by default.
Some pages which use the account layout belong under "Manage your account" instead of "Your account".
This allows us the option to render the account layout with "Manage your account" selected/active in the account nav, instead of the default "Your account".
gem_layout_account_manager template
gem_layout_account_manager_manage_your_account_active template
This also ensures the Account link in the site header nav appears with the correct active blue colour (currently there is no visual difference between the Account link and the Sign out one)
https://trello.com/c/uDkZ90GE