Add feature flag for new link styles #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! One liner Local static + collections looks good here: |
chris-gds
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Had a checks across URLs: 🎉
http://collections.dev.gov.uk/coronavirus
http://collections.dev.gov.uk/coronavirus/education-and-childcare
http://collections.dev.gov.uk/education
http://collections.dev.gov.uk/government/organisations/cabinet-office
http://collections.dev.gov.uk/government/organisations/hm-revenue-customs/services-information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Apply's the feature flag for new link styles from the latest release of GOV.UK Frontend
Why
For the new gem layout, the component styles in static are overriding a few things across govuk apps. This has meant that apps that are currently set to use the new link styles and the gem layout are using mixed link styles. This ensure that we are using the new link styles everywhere.