Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct component references #2391

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

andysellick
Copy link
Contributor

Update component references following this change to correct component file names: alphagov/govuk_publishing_components#1848

- this component asset has been renamed to match conventions, so updating its references here
@bevanloon bevanloon temporarily deployed to govuk-static-fix-compon-8t9ewc January 14, 2021 17:20 Inactive
maxgds
maxgds previously approved these changes Jan 18, 2021
@maxgds maxgds dismissed their stale review January 18, 2021 09:00

Not sure this is right, shouldn't it be an underscore rather than a hyphen?

Copy link
Contributor

@maxgds maxgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about confusion on my part between js and component call in previous review.

@andysellick andysellick merged commit c945e2c into master Jan 18, 2021
@andysellick andysellick deleted the fix-component-references branch January 18, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants