Bump govuk_publishing_components from 23.10.1 to 23.12.1 #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 23.10.1 to 23.12.1. - [Release notes](https://github.com/alphagov/govuk_publishing_components/releases) - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/master/CHANGELOG.md) - [Commits](alphagov/govuk_publishing_components@v23.10.1...v23.12.1) Signed-off-by: dependabot[bot] <[email protected]>
ChrisBAshton
approved these changes
Jan 11, 2021
ChrisBAshton
deleted the
dependabot/bundler/govuk_publishing_components-23.12.1
branch
ChrisBAshton
added a commit
that referenced
this pull request
Jan 12, 2021
We have to `require "active_support/time"` to define these helper methods, which are used to set the Cache-Control header in the [test][] and [development][] environments. I don't know why bumping the govuk_publishing_components gem from v23.10.1 to v23.12.1 has caused this issue in both [Static][] and [Feedback][] (nor why the tests passed on the PR and only subsequently failed after merge). Looking at the Gemfile.lock changes in Static (in 7c79e8d), there's no obvious culprit there. I tried reverting the versions of all dependencies except govuk_publishing_components, but the issue remained. Looking at the [diff between the gem versions][diff], there are no code changes that could have caused this, but there are a number of Gemfile.lock changes including a minor bump in `activesupport`, from 6.0 to 6.1, but we've already [upgraded activesupport via a rails bump][rails-bump], so I'm not sure why that would be an issue. It won't be a good use of time to investigate too much further, so I'm happy that this is a harmless change which unblocks us from deploying an important fix. Trello: https://trello.com/c/YhIIykse/2291-3-fix-cross-site-scripting-vulnerabilities [diff]: https://github.com/alphagov/govuk_publishing_components/compare/v23.10.1..v23.12.1 [development]: https://github.com/alphagov/static/blob/8d40903636dba086f855e3f18a99fa02af5055b8/config/environments/development.rb#L23 [test]: https://github.com/alphagov/static/blob/c2b5079b83094b540ad600663fe656a87bb50df9/config/environments/test.rb#L19 [Static]: #2379 [Feedback]: alphagov/feedback#1149 [rails-bump]: 962f64a
ChrisBAshton
added a commit
to alphagov/feedback
that referenced
this pull request
Jan 12, 2021
We have to `require "active_support/time"` to define the helper methods we use to set the Cache-Control header in the [test environment][usage]. I don't know why bumping the govuk_publishing_components gem from v23.10.1 to v23.12.1 has caused this issue in both [Static][] and [Feedback][] (nor why the tests passed on the PR and only subsequently failed after merge). I write up an investigation in alphagov/static#2384, but have nothing conclusive. It won't be a good use of time to investigate too much further, so I'm happy that this is a harmless change which unblocks us from deploying an important fix. Trello: https://trello.com/c/YhIIykse/2291-3-fix-cross-site-scripting-vulnerabilities [Static]: alphagov/static#2379 [Feedback]: #1149 [usage]: https://github.com/alphagov/feedback/blob/1cfe51bc39ec48f2cba0c502b15720fdc4dbbcd2/config/environments/test.rb#L14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps govuk_publishing_components from 23.10.1 to 23.12.1.
Changelog
Sourced from govuk_publishing_components's changelog.
Commits
1f6eeb2Merge pull request #1861 from alphagov/new-23.12.166c0d94Bump to 23.12.1e17aec2Merge pull request #1860 from alphagov/dependabot/bundler/govuk_app_config-2.8.26608652Merge pull request #1859 from alphagov/dependabot/bundler/rails-6.1.1cd0ed9dMerge pull request #1857 from alphagov/dependabot/bundler/nokogiri-1.11.14c77f65Merge pull request #1856 from alphagov/dependabot/bundler/gds-api-adapters-68...a944b65Merge pull request #1858 from alphagov/escape-dangerous-html46263d7Bump govuk_app_config from 2.8.1 to 2.8.2e18c5afBump rails from 6.0.3.4 to 6.1.1f80ce6bEscape dangerous HTML in 'Machine readable metadata' componentDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)