Fix search label cut off text #2305
Conversation
The global site header search label text has been updated from "Search" to "Search on GOV.UK". This has lead to an issue where the label text is now appearing clipped on larger mobile adaptations as there simply is not enough space to accommodate it. This updates the CSS so that the search field is hidden on larger mobiles – same as it currently is for smaller mobiles. The search form can be shown/hidden using the search toggle button.
| @@ -104,15 +105,18 @@ | |||
| .search-toggle { | |||
There was a problem hiding this comment.
What do you think about making the styles for .search-toggle mobile first so the display: none would kick in ($from: tablet) instead of being overwritten?
There was a problem hiding this comment.
Hi @injms that's a good point – @chris-gds has actually mentioned this too 👍.
My rationale here is that the aim of this piece of work is to fix the issue by replacing the old media query style with the govuk-media-query equivalent.
This other PR removes a whole bunch of CSS and refactors the code so that it is mobile first, so I simply didn't want to repeat that on here in the interest of minimising potential conflicts/repetition (but I suppose there will be some conflicts either way, so I don't know... let me know what you think)
|
In Firefox, I'm seeing a slight overlap of the focus state:
|
|
Closing this PR as #2293 has been approved and also fixes the issue. |
The global site header search label text has been updated from "Search" to "Search on GOV.UK".
This has lead to an issue where the label text is now appearing clipped on larger mobile adaptations as there simply is not enough space to accommodate it.
Problem
This updates the CSS so that the search field is hidden on larger mobiles – same as it currently is for smaller mobiles. The search form can be shown/hidden using the search toggle button.
Solution
Thanks @issyl0 for bringing this to our attention 👉🏼 👉🏼 👉🏼 #2301
https://trello.com/c/RbD3om74