Make mobile menu toggle a button #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- was formerly a link, which failed accessibility requirements because it behaved like a button - uses existing JS for this (header-navigation.js, in govuk_publishing_components for reference, fact fans) - copied and modified the styling from govuk-template (as it no longer applies) in order to preserve the look of the element exactly, CSS may therefore not be as nice as it could be, but this should all be replaced by the proper header at some point anyway
injms
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Checked with @selfthinker about whether this needs to look like a button, or whether this needs to be a button element - and she's confirmed that this needs to be a button element. So all 👍
🧪👨🏻🎤🙆🏻♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be no visual changes.
Trello card: https://trello.com/c/2bL11sIv/414-mobile-menu-button-looks-like-a-link
Interesting note - this code for the menu toggle is in
static(obviously). The JS that controls it (and also the search toggle for mobile, just above it) is ingovuk_publishing_components. The menu that appears when you toggle this button appears to come fromwhitehall(https://github.com/alphagov/whitehall/blob/master/app/views/layouts/frontend.html.erb).The sooner we get the header consolidated into one component the better.