Fix crash on cookie setting #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
force-pushed
the
fix-cookies-bug
branch
from
5bf989c to
9c4c6c2
Compare
The banner code was trying to manipulate a cookie that may not yet exist. This sets the default if none is present and removes a redundant if statement.
maxgds
force-pushed
the
fix-cookies-bug
branch
from
9c4c6c2 to
130254d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The banner code was trying to manipulate a cookie that doesn't
yet exist. This sets the default if none is present and removes
a redundant if statement.
The bug can be seen by going in an incognito window (so no cookies are set for the site) to http://www.gov.uk/help/cookies - the js crashes and makes it impossible to set cookie preferences which is the purpose of that page. This probably only affects this page as elsewhere the cookie defaults are set in the cookie banner that is excluded from appearing here.