Upgrade application to Rails 6.0 #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdccollins
approved these changes
Aug 11, 2020
pixeltrix
force-pushed
the
upgrade-to-rails-6
branch
from
1cd4910 to
f2083f8
Compare
Use the Gemfile.lock to manage the versions instead which should make it easier to upgrade as it allows bundler a wider set of versions to resolve the dependencies. Keep the rails constraint so that the current version can be identified.
Remove unused gems and helpers from test base class.
The Rakefile is loaded automatically by the rake command and is not designed to be executed directly.
Rails 4.0 and later disable rack-cache by default.
Note that the specs can't run in random order due to cookies being carried over between specs.
The bug with subresource integrity BOMs was fixed in Firefox 52.
This is now required in the Gemfile from commit 2a5c239.
Individual changes reviewed to ensure that application behaviour is maintained and any obsolete configuration options are removed.
Otherwise the Rails route mapper will raise an error on a missing :controller key in the route definition.
Using a sass css compressor causes a scss file to be processed twice (once to build, once to compress) which breaks the usage of "unquote" to use CSS that has same function names as SCSS such as max.
Calling `render file:` with a relative path has been deprecated so use `render template:` with the same path which finds the layout anyway.
Rails 6.0 adds a host authentication middleware that limits access by default to 0.0.0.0/0, ::/0 and localhost. This commit adds the dev.gov.uk hosts for the application to that list. There's no need to add the hosts in production since the middleware is primarily to prevent DNS rebinding attacks against a Rails application running locally.
Once the app is configured to load the latest defaults there is no need for the new defaults initializer as it only serves as a guide whilst upgrading the application.
The Rails secrets feature has been deprecated and will be removed in an upcoming release. Rails 6.0 will generate a secret_key_base file in the tmp directory in development and test environments and use the SECRET_KEY_BASE environment variable in production.
Inline with the suggestion in alphagov/govuk-rfcs#126 update the remaining minor dependencies when doing a framework upgrade.
pixeltrix
force-pushed
the
upgrade-to-rails-6
branch
from
f2083f8 to
2493fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.