Now matches the exact path for url blocking #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihugh
reviewed
Mar 23, 2020
Previously it was checking for segments so if we had `/coranavirus` blocked, `/guidance/coronavirus-covid-19-information-for-the-public` would be blocked too as it has `/coronavirus` in the middle. This change now forces the regex to check exact match so it would only match if the path is `/coronavirus` not `/guidance/coronavirus-covid-19-information-for-the-public`. Trello: https://trello.com/c/a83JfZDG/60-check-why-the-banner-doesnt-appear-on-certain-pages
DilwoarH
force-pushed
the
regex-for-exact-match
branch
from
bb9fa6c to
a8a94eb
Compare
sihugh
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was checking for segments so if we had
/coranavirusblocked,/guidance/coronavirus-covid-19-information-for-the-publicwould be blocked too as it has/coronavirusin the middle.This change now forces the regex to check exact match so it would only match if the path is
/coronavirusnot/guidance/coronavirus-covid-19-information-for-the-public.Trello: https://trello.com/c/a83JfZDG/60-check-why-the-banner-doesnt-appear-on-certain-pages