Fix global bar multiple cookies #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
fix-global-bar-multiple-cookies
branch
from
1005202 to
75980f2
Compare
|
(sorry, still need to test on various frontend apps in integration. Will invite for review once I've done more testing) |
added 3 commits
February 5, 2020 11:26
We had an issue where the global bar was setting 2 global_bar_seen cookies on some pages. The initialise logic was setting a cookie with the path of the page, whereas other logic was using GOVUK.setCookie() which sets with a path of "/". This commit switches the initialise logic to use GOVUK.setCookie() too, so the path is the same and we only have one cookie.
vanitabarrett
force-pushed
the
fix-global-bar-multiple-cookies
branch
from
75980f2 to
e739f44
Compare
|
Ready for review now - seems to fix the issue when I tested on integration |
alex-ju
approved these changes
Feb 5, 2020
vanitabarrett
pushed a commit
that referenced
this pull request
Feb 10, 2020
We had a bug which meant that the global_bar_seen cookie was sometimes set more than once. This bug has now been fixed (#2026), but some users will be left with these duplicate cookies and therefore will continue to see the issue. This commit introduces a function that checks for these duplicate cookies and deletes them if they're present.
vanitabarrett
pushed a commit
that referenced
this pull request
Feb 10, 2020
We had a bug which meant that the global_bar_seen cookie was sometimes set more than once. This bug has now been fixed (#2026), but some users will be left with these duplicate cookies and therefore will continue to see the issue. This commit introduces a function that checks for these duplicate cookies and deletes them if they're present.
vanitabarrett
pushed a commit
that referenced
this pull request
Feb 10, 2020
We had a bug which meant that the global_bar_seen cookie was sometimes set more than once. This bug has now been fixed (#2026), but some users will be left with these duplicate cookies and therefore will continue to see the issue. This commit introduces a function that checks for these duplicate cookies and deletes them if they're present.
vanitabarrett
pushed a commit
that referenced
this pull request
Feb 10, 2020
We had a bug which meant that the global_bar_seen cookie was sometimes set more than once. This bug has now been fixed (#2026), but some users will be left with these duplicate cookies and therefore will continue to see the issue. This commit introduces a function that checks for these duplicate cookies and deletes them if they're present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/hA65u9qV/460-global-banner-setting-two-cookies-on-some-pages
What
Use cookie helper functions in the global bar init logic, to match the rest of the global bar logic.
Why
The global banner was setting two cookies on some pages, one with a path of '/' and one with the path of the page. This had the side effect of the banner not being able to be dismissed (it also didn't disappear after 3 page views). This looked like it was happening because some of the global bar functions set the cookie manually without specifying a path, whereas other functions use the cookie helper function which always set the path to '/'.
Example page to check:
www.gov.uk/government/organisations/companies-house