Move measurement into static from toolkit #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copied the spacing function from GOV.UK Frontend over into it's own stylesheet - this should be removed when possible to avoid stagnation. - Removed the `govuk_toolkit` measurements partial from the header-footer stylesheet
- The `$gutter` variables have been replaced with `govuk-spacing(x)` with drastic no change.
- All spacings set in pixels that can be replaced witha `govuk-spacing(x)` function have been replaced. - There are a fair few magic numbers dotted around the place, which can be looked at when the updated version of the Transport font is being used. These are outside the scope of this task at the moment.
injms
changed the title
vanitabarrett
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moved the spacing function (
govuk-spacing(𝖷)) into static so it can be used without importing all of the publishing components gem.Replaced the all of the
$guttervariables and hardcoded variables that could be directly replaced with a spacing function without impacting the layout. So30pxand$gutterwere replaced withgovuk-spacing(6), but any magic numbers like48pxwere left alone.Why
The Sass functions and variables are useful. But if we import publishing components we'll inflate the amount of CSS in static dramatically - so we need to add just the functions and variables on their own. This is a quick way of doing it until the publishing components gem allows only importing specific parts on their own.
Visual changes
None