Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add register to vote banner #1934

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Add register to vote banner #1934

merged 1 commit into from
Nov 11, 2019

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Nov 11, 2019 •
edited
Loading

Trello: https://trello.com/c/Lu2x8C4G/236-add-register-to-vote-banner

What

  • Updates global banner content to point to Register to Vote page
  • Adds logic to support an automatic turn off date and time
  • Sets automatic turn off datetime to 11:59pm on 26th November 2019

Screen Shot 2019-11-11 at 11 37 39

@bevanloon bevanloon temporarily deployed to govuk-static-test-depl-pr-1934 November 11, 2019 12:37 Inactive
benthorner
benthorner reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@benthorner benthorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to increment the cookie version so this reappears for people?

@vanitabarrett vanitabarrett force-pushed the register-to-vote-banner branch from cd76d52 to da48708 Compare November 11, 2019 13:31
benthorner
benthorner approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@benthorner benthorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vanitabarrett vanitabarrett merged commit 14d924f into master Nov 11, 2019
@vanitabarrett vanitabarrett deleted the register-to-vote-banner branch November 11, 2019 13:48
vanitabarrett pushed a commit that referenced this pull request Dec 2, 2019
Remove close date logic from banner
873f3f3 
We previously added logic in #1934 to automatically take down the banner at a specified close date.
However, this didn't work as expected due to templates being cached when they are requested by Slimmer. Bypassing this caching would be more challenging and as there isn't an immediate use case for this work (we can manually remove the banner instead) we're going to remove this logic for now.

If this feature is requested in the future, we now know that this is more difficult to implement than we first thought and can scope accordingly.
@vanitabarrett vanitabarrett mentioned this pull request Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benthorner benthorner benthorner approved these changes

@huwd huwd Awaiting requested review from huwd

@koetsier koetsier Awaiting requested review from koetsier

@DilwoarH DilwoarH Awaiting requested review from DilwoarH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanitabarrett @benthorner @bevanloon