Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error page template #1868

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Fix error page template #1868

merged 2 commits into from
Sep 19, 2019

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Sep 19, 2019

The error-page template, used for rendering 4xx and 5xx pages, is currently missing the jQuery import (as flagged in #1862) and doesn't have the compatibility with govuk_template flag turned on - this is needed for the cookie banner and feedback component used on the pages.

Fixes #1862.

@alex-ju alex-ju merged commit 4c2b0f2 into master Sep 19, 2019
@alex-ju alex-ju deleted the fix-error-page-template branch September 19, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Uncaught ReferenceError: jQuery is not defined" on 404 pages
3 participants