Use pii code in cross linker #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andysellick
commented
Sep 12, 2019
andysellick
commented
- avoids duplication, already had email stripping code
- also now includes dates and postcodes
bilbof
reviewed
Sep 12, 2019
app/assets/javascripts/analytics_toolkit/google-analytics-universal-tracker.js
Outdated
Show resolved
Hide resolved
bilbof
approved these changes
Sep 12, 2019
- avoids duplication, already had email stripping code - also now includes dates and postcodes
andysellick
force-pushed
the
use-pii
branch
from
92d990d to
46fd7f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.