Change linker code calling approach #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- have added a test, which appears to produce the result we want - now calling the linker code once, but with multiple domains
andysellick
force-pushed
the
linker-experiment
branch
from
092a11e to
5162640
Compare
andysellick
changed the title
| @@ -40,7 +40,7 @@ | |||
|
|
|||
| // Make interface public for virtual pageviews and events | |||
| GOVUK.analytics = analytics; | |||
| GOVUK.analytics.addLinkedTrackerDomain(secondaryId, 'govuk', 'design-system.service.gov.uk'); | |||
| GOVUK.analytics.addLinkedTrackerDomain(secondaryId, 'govuk', 'design-system.service.gov.uk, passport.service.gov.uk, apply-for-eu-settled-status.homeoffice.gov.uk'); | |||
There was a problem hiding this comment.
Suggested change
| GOVUK.analytics.addLinkedTrackerDomain(secondaryId, 'govuk', 'design-system.service.gov.uk, passport.service.gov.uk, apply-for-eu-settled-status.homeoffice.gov.uk'); | |
| GOVUK.analytics.addLinkedTrackerDomain(secondaryId, 'govuk', 'design-system.service.gov.uk', 'passport.service.gov.uk', 'apply-for-eu-settled-status.homeoffice.gov.uk'); |
Is it missing quotes?
There was a problem hiding this comment.
I believe not, no. I think it's supposed to be like that.
There was a problem hiding this comment.
My plan is to have a revert ready. Unfortunately the only way to test this is working and to be sure of it is to deploy it to live :(
theseanything
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we might have been calling the linker code incorrectly. Rather than calling it once for each linked domain required, we should call it once but with all the domains.
The previous method was causing duplicate GA events to be fired, one for each call to the linker code.
This PR also adds a test for calling the code this way.