Run Javascript tests on default bundle exec rake #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, Javascript tests aren't run when you run `bundle exec rake`. They are only run when running `bundle exec rake spec:javascript`. This can mean failing tests go unnoticed until you push to Github and the build fails on CI. This expands the default task to include `spec:javascript`.
alex-ju
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Expands the default task (
bundle exec rake) to includespec:javascript.Why
At the moment, Javascript tests aren't run when you run
bundle exec rake- they are only run when runningbundle exec rake spec:javascript. This means failing tests can go unnoticed until you push to Github and the build fails on CI.Note: the Jenkins build remains unchanged, as it already runs
testandspec:javascriptseparately