Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking event when link in banner is pressed #1585

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

NickColley
Copy link
Contributor

In order to know how successful the banners are we want to know if users are getting to the right place (which may be an external link).

@NickColley NickColley changed the title Add tracking event when link in banner is pressed [Do not merge] Add tracking event when link in banner is pressed Dec 6, 2018
Copy link
Contributor

@steventux steventux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly generated a GA event like

ga("send", {hitType: "event", eventCategory: "Global bar", eventAction: "https://www.gov.uk/",
... 
})

@NickColley NickColley changed the title [Do not merge] Add tracking event when link in banner is pressed Add tracking event when link in banner is pressed Dec 6, 2018
@NickColley NickColley merged commit bb14ffa into master Dec 6, 2018
@NickColley NickColley deleted the add-tracking-for-call-to-action-banner-link branch December 6, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants