Add banner support #1583
Merged
Add banner support #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 3, 2018 12:00
This may be used for upcoming important announcements on GOV.UK
Content and design TBC, this resurrects code from 4cebe28
added 2 commits
December 4, 2018 12:45
Move the banner up to sit directly below the GOV.UK header and hide the blue global-header-bar element. This element will display when the banner is dismissed or automatically hidden.
This commit moves the banner activation js and markup into one location and adds the ability to easily edit the content of the banner. The banner can be shown or hidden based on a boolean.
andysellick
reviewed
Dec 4, 2018
steventux
force-pushed
the
add-banner-support
branch
from
6d7e566 to
3fdc23e
Compare
steventux
force-pushed
the
add-banner-support
branch
from
54ae8c3 to
208f7f4
Compare
|
@andysellick are you OK with review replies/updates? |
We've evaluated a couple of different design ideas and decided on a slightly different colour for the global banner.
|
@steventux all but one, I've added a comment. |
|
@steventux all looks good now. |
bevanloon
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/ItwW03vg/48-build-a-generic-banner-based-on-an-older-banner-pattern
This PR resurrects previous banner code as the rules and design pattern works well for general site wide announcements which are not suitable for emergency banner content.
This can be merged as the banner is not enabled: https://github.com/alphagov/static/pull/1583/files#diff-e17896925164fa4471101aca24b30733R2
This is based on code from #769
Future iterations should address: