Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse flag to lead paragraph component #1318

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Mar 6, 2018

We need to be able to display the lead paragraph component as white text on a blue background for the new taxonomy topic page designs.

screen shot 2018-03-06 at 11 29 25

Component Guide link

@tijmenb tijmenb temporarily deployed to govuk-static-pr-1318 March 6, 2018 11:22 Inactive
@vanitabarrett vanitabarrett force-pushed the allow-lead-para-blue-background branch from eff591f to d08df42 Compare March 6, 2018 16:08
@fofr fofr temporarily deployed to govuk-static-pr-1318 March 6, 2018 16:08 Inactive
maxgds
maxgds previously requested changes Mar 7, 2018
Copy link
Contributor

@maxgds maxgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding a line to the accessibility criteria to note that the component must be used with sufficient background/foreground contrast, particularly if the inverse flag is set?

@vanitabarrett
Copy link
Contributor Author

@maxgds Good spot, I'll add that now 👍

We need to be able to display the lead paragraph component as white text on a blue background for the new taxonomy topic page designs
Copy link
Contributor

@maxgds maxgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vanitabarrett vanitabarrett merged commit f76b13c into master Mar 7, 2018
@vanitabarrett vanitabarrett deleted the allow-lead-para-blue-background branch March 7, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants