Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design of taxonomy sidebar #1200

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Nov 22, 2017

We are developing a new navigation sidebar component in government-frontend. We need to bring the taxonomy sidebar component design in line with the new related links. Ideally we'd be updating this component to follow our component conventions, e.g: using BEM, but this is probably a bigger piece of work, especially with the caching issues we've had previously when updating static components.

Component Guide: https://govuk-static-pr-1200.herokuapp.com/component-guide/taxonomy_sidebar

Note: this change will affect the taxonomy sidebar across all applications (not just government-frontend). Example pages to tests are:

Design

Navigation Sidebar Component:
screen shot 2017-11-22 at 16 20 11

Taxonomy Sidebar Component
screen shot 2017-11-24 at 13 38 31

@fofr fofr temporarily deployed to govuk-static-pr-1200 November 22, 2017 15:40 Inactive
@vanitabarrett vanitabarrett force-pushed the update-taxonomy-sidebar-design branch from eb30feb to 8110ddb Compare November 22, 2017 16:01
@fofr fofr temporarily deployed to govuk-static-pr-1200 November 22, 2017 16:01 Inactive
@vanitabarrett vanitabarrett force-pushed the update-taxonomy-sidebar-design branch from 8110ddb to b1335c9 Compare November 22, 2017 16:27
@fofr fofr temporarily deployed to govuk-static-pr-1200 November 22, 2017 16:27 Inactive
@vanitabarrett vanitabarrett force-pushed the update-taxonomy-sidebar-design branch from b1335c9 to 9930e8e Compare November 22, 2017 16:37
@fofr fofr temporarily deployed to govuk-static-pr-1200 November 22, 2017 16:38 Inactive
@vanitabarrett vanitabarrett force-pushed the update-taxonomy-sidebar-design branch from 9930e8e to bf3a5fb Compare November 23, 2017 14:58
@fofr fofr temporarily deployed to govuk-static-pr-1200 November 23, 2017 14:58 Inactive
@vanitabarrett vanitabarrett changed the title [WIP] Update design of taxonomy sidebar Update design of taxonomy sidebar Nov 24, 2017
@vanitabarrett vanitabarrett force-pushed the update-taxonomy-sidebar-design branch from bf3a5fb to b5e75bb Compare November 24, 2017 13:38
@fofr fofr temporarily deployed to govuk-static-pr-1200 November 24, 2017 13:38 Inactive
@vanitabarrett vanitabarrett force-pushed the update-taxonomy-sidebar-design branch from b5e75bb to 19cf509 Compare November 24, 2017 13:45
@fofr fofr temporarily deployed to govuk-static-pr-1200 November 24, 2017 13:45 Inactive
@vanitabarrett vanitabarrett force-pushed the update-taxonomy-sidebar-design branch from 19cf509 to 3c21cae Compare November 24, 2017 13:55
@fofr fofr temporarily deployed to govuk-static-pr-1200 November 24, 2017 13:56 Inactive
We are developing a new related links component in government-frontend. We need to bring the taxonomy sidebar component design in line with the new related links.
Copy link
Contributor

@maxgds maxgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vanitabarrett vanitabarrett merged commit 1033633 into master Nov 27, 2017
@vanitabarrett vanitabarrett deleted the update-taxonomy-sidebar-design branch November 27, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants