-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'require' logic from Gemfile #1137
Conversation
Nice! We should probably add this to https://github.com/alphagov/govuk_publishing_components#install-gem and also update government-frontend https://github.com/alphagov/government-frontend/blob/master/Gemfile#L11 |
Could you add a comment in the gemfile to explain what we're doing here, so people are not confused at why it's false but still displaying in development/heroku |
@NickColley Isn't that what |
@whoojemaflip as someone who doesn't frequent gemfiles that's not something I'd know off the top of my head, but yeah it does make sense on it's own I guess... |
Seems to be working as expected: |
I'm going to update the gem and government-frontend with this in mind. |
Move the decision point for the
require
out of the Gemfile and into application.rb