Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'require' logic from Gemfile #1137

Merged
merged 2 commits into from
Sep 8, 2017
Merged

Conversation

whoojemaflip
Copy link
Contributor

Move the decision point for the require out of the Gemfile and into application.rb

@fofr fofr requested a deployment to govuk-static-pr-1137 September 8, 2017 11:56 Pending
@fofr fofr requested a deployment to govuk-static-pr-1137 September 8, 2017 11:56 Pending
@fofr fofr requested a deployment to govuk-static-pr-1137 September 8, 2017 11:56 Pending
@fofr fofr requested a deployment to govuk-static-pr-1137 September 8, 2017 11:57 Pending
@NickColley
Copy link
Contributor

@NickColley
Copy link
Contributor

Could you add a comment in the gemfile to explain what we're doing here, so people are not confused at why it's false but still displaying in development/heroku

@whoojemaflip
Copy link
Contributor Author

whoojemaflip commented Sep 8, 2017

@NickColley Isn't that what require: false in a Gemfile signifies? That a gem will be required by hand rather than by magic / bundler.

@NickColley
Copy link
Contributor

NickColley commented Sep 8, 2017

@whoojemaflip as someone who doesn't frequent gemfiles that's not something I'd know off the top of my head, but yeah it does make sense on it's own I guess...

@fofr fofr requested a deployment to govuk-static-pr-1137 September 8, 2017 12:26 Pending
@fofr fofr requested a deployment to govuk-static-pr-1137 September 8, 2017 12:31 Pending
@fofr fofr requested a deployment to govuk-static-pr-1137 September 8, 2017 12:45 Pending
@fofr fofr temporarily deployed to govuk-static-pr-1137 September 8, 2017 13:02 Inactive
@fofr
Copy link
Contributor

fofr commented Sep 8, 2017

Seems to be working as expected:
http://govuk-static-pr-1137.herokuapp.com/component-guide/

@NickColley NickColley merged commit 3d42d38 into master Sep 8, 2017
@NickColley NickColley deleted the remove-logic-from-gemfile branch September 8, 2017 15:21
@NickColley
Copy link
Contributor

I'm going to update the gem and government-frontend with this in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants