Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count finder sections as one #1105

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Count finder sections as one #1105

merged 1 commit into from
Jul 28, 2017

Conversation

carvil
Copy link
Contributor

@carvil carvil commented Jul 28, 2017

We should default to 1 section in all finders, so that it's comparable with navigations with only an A-Z section.

This is a request from Vin, performance analyst.

Trello: https://trello.com/c/vRtpDbnk/56-investigate-getting-nav-beta-analytics-tracking-onto-finder-template

Copy link
Contributor

@whoojemaflip whoojemaflip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should default to 1 section in all finders, so that it's comparable
with navigations with only an A-Z section.

This is a request from Vin, performance analyst.

Trello: https://trello.com/c/vRtpDbnk/56-investigate-getting-nav-beta-analytics-tracking-onto-finder-template
@carvil carvil force-pushed the count-finder-sections-as-one branch from d5fbfb4 to f726e85 Compare July 28, 2017 11:28
@carvil carvil merged commit 7d56d80 into master Jul 28, 2017
@carvil carvil deleted the count-finder-sections-as-one branch July 28, 2017 11:31
@carvil carvil changed the title [DO NOT MERGE] Count finder sections as one Count finder sections as one Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants