Fix for sticky contents link overlap issue #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* At foot of page was possible to get 'Contents' fixed position link to briefly overlap content below it * Problem was due to height of parent element including height of Contents link, then changing after it was set to position fixed * Fixed by defaulting Contents link to position absolute so it never adds any height to the parent
* CSS precedence was broken making contents link still be visible at top of page when it shouldn't have been
fofr
reviewed
Jun 7, 2017
| } | ||
| } | ||
| position: absolute; | ||
| bottom: 0; | ||
|
|
||
| &--stuck-to-parent { |
There was a problem hiding this comment.
Is this block used now? Can it be removed? I can't find any references to stuck-to-parent.
|
When the JS fails on mobile it looks broken: Old
New
|
fofr
suggested changes
Jun 7, 2017
* Fixed styles so link appears correctly if JS disabled * Removed unnecessary class --stuck-to-parent
|
Have removed unnecessary CSS and fixed when JS disabled. |
fofr
approved these changes
Jun 8, 2017
|
Link behaves nicer now, top work 💯 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to alphagov/government-frontend#367