Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Navigation Tracking Metatags shim #1032

Merged
merged 1 commit into from
May 8, 2017
Merged

Add Navigation Tracking Metatags shim #1032

merged 1 commit into from
May 8, 2017

Conversation

alecgibson
Copy link
Contributor

In order to remove the navigation analytics meta tags, we need to do
two stages:

  1. Remove all references to the meta tags (ie in taxonomy sidebar
    and related items)
  2. Remove the component itself

This is because Static/Slimmer will have a cached set of sidebar
components that will continue trying to use the old meta tags. Hence
we need to leave the meta tags in place, and then remove them after
the cache has cleared.

In order to remove the navigation analytics meta tags, we need to do
two stages:

1. Remove all references to the meta tags (ie in taxonomy sidebar
   and related items)
2. Remove the component itself

This is because Static/Slimmer will have a cached set of sidebar
components that will continue trying to use the old meta tags. Hence
we need to leave the meta tags in place, and then remove them after
the cache has cleared.
@carvil carvil merged commit 576465c into master May 8, 2017
@carvil carvil deleted the add-tracking-shim branch May 8, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants