Allow for a description in related link sections #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is required so we can display the new Register to Vote section in the related links sidebar. Because there needs to be a description in there, we need to make sure we add it to the section, when available.
alecgibson
approved these changes
May 5, 2017
carvil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required so we can display the new Register to Vote
section in the related links sidebar. Because there needs to be a
description in there, we need to make sure we add it to the section,
when available.
Trello: https://trello.com/c/QbnidEBA/97-add-promotion-for-register-to-vote-to-transaction-done-pages
Waiting on product/design feedback before this should be merged. This needs data from
govuk_navigation_helpersin order to display the description. The PR is here: alphagov/govuk_navigation_helpers#76It currently looks like this: