Merge pull request #1482 from alphagov/brakeman

Enable Brakeman
alphagov · Aug 3, 2018 · bf374c0 · bf374c0
2 parents 861d8f9 + c71b9a8
commit bf374c0
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -16,5 +16,6 @@ node {
       }
     },
     publishingE2ETests: true,
+    brakeman: true,
   )
 }
diff --git a/config/brakeman.ignore b/config/brakeman.ignore
@@ -0,0 +1,26 @@
+{
+  "ignored_warnings": [
+    {
+      "warning_type": "Dynamic Render Path",
+      "warning_code": 15,
+      "fingerprint": "0a4ebe31686d3a336e8746a0562a643ef742503fdf160807cf8ee2109f539609",
+      "check_name": "Render",
+      "message": "Render path contains parameter value",
+      "file": "app/controllers/root_controller.rb",
+      "line": 20,
+      "link": "https://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
+      "code": "render(action => params[:template], { :layout => \"govuk_template\" })",
+      "render_path": null,
+      "location": {
+        "type": "method",
+        "class": "RootController",
+        "method": "template"
+      },
+      "user_input": "params[:template]",
+      "confidence": "High",
+      "note": "We validate the parameter in validate_template_param to check it contains no slashes or underscores."
+    }
+  ],
+  "updated": "2018-08-02 15:21:08 +0100",
+  "brakeman_version": "4.3.1"
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,5 +16,6 @@ node { @@
           }
         },
         publishingE2ETests: true,
+        brakeman: true,
       )
     }