Skip to content

Commit

Permalink
Use image-url scss helper.
Browse files Browse the repository at this point in the history
A few images weren't using this.  This means that they were using the
non-digest variant in production, which will get shorter cache times,
and also won't pick up changes as quickly because the filename won't
change when the contents change.
  • Loading branch information
alext committed Dec 11, 2013
1 parent d7e7cb4 commit 8f7cd60
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion app/assets/stylesheets/_buttons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
}

@include ie(6) {
background-image: url('icon-pointer-indexed.png');
background-image: image-url('icon-pointer-indexed.png');
}

@include device-pixel-ratio() {
Expand Down
4 changes: 2 additions & 2 deletions app/assets/stylesheets/_header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
overflow: hidden;
text-indent: -5000px;
background-color: $light-blue;
background-image: url("search-button.png");
background-image: image-url("search-button.png");
background-repeat: no-repeat;
background-position: 0 50%;

Expand Down Expand Up @@ -161,7 +161,7 @@

color: $white;
background-color: $mainstream-brand;
background-image: url("search-button.png");
background-image: image-url("search-button.png");
background-repeat: no-repeat;
background-position: 0 50%;

Expand Down
24 changes: 12 additions & 12 deletions app/assets/stylesheets/organisations.scss
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
@include organisation-logo-image('crests/bis_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/bis_crest_13px.png')
background-image: image-url('crests/bis_crest_13px.png')
}
}

Expand All @@ -135,15 +135,15 @@
@include organisation-logo-image('crests/coastguard_18px.png');

@include media-down(mobile) {
background-image: url('crests/coastguard_13px.png')
background-image: image-url('crests/coastguard_13px.png')
}
}

.organisation-logo-hmrc {
@include organisation-logo-image('crests/hmrc_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/hmrc_crest_13px.png')
background-image: image-url('crests/hmrc_crest_13px.png')
}
}

Expand All @@ -153,7 +153,7 @@
@include organisation-logo-image('crests/ho_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/ho_crest_13px.png')
background-image: image-url('crests/ho_crest_13px.png')
}
}

Expand All @@ -163,7 +163,7 @@
@include organisation-logo-image('crests/mod_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/mod_crest_13px.png')
background-image: image-url('crests/mod_crest_13px.png')
}
}

Expand All @@ -177,39 +177,39 @@
@include organisation-logo-image('crests/org_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/org_crest_13px.png')
background-image: image-url('crests/org_crest_13px.png')
}
}

.organisation-logo-portcullis {
@include organisation-logo-image('crests/portcullis_18px.png');

@include media-down(mobile) {
background-image: url('crests/portcullis_crest_13px.png')
background-image: image-url('crests/portcullis_crest_13px.png')
}
}

.organisation-logo-so {
@include organisation-logo-image('crests/so_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/so_crest_13px.png')
background-image: image-url('crests/so_crest_13px.png')
}
}

.organisation-logo-single-identity {
@include organisation-logo-image('crests/org_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/org_crest_13px.png')
background-image: image-url('crests/org_crest_13px.png')
}
}

.organisation-logo-ukaea {
@include organisation-logo-image('crests/ukaea_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/ukaea_crest_13px.png')
background-image: image-url('crests/ukaea_crest_13px.png')
}
}

Expand All @@ -219,7 +219,7 @@
@include organisation-logo-image('crests/ukho_18px.png');

@include media-down(mobile) {
background-image: url('crests/ukho_13px.png')
background-image: image-url('crests/ukho_13px.png')
}
}

Expand All @@ -229,6 +229,6 @@
@include organisation-logo-image('crests/wales_crest_18px.png');

@include media-down(mobile) {
background-image: url('crests/wales_crest_13px.png')
background-image: image-url('crests/wales_crest_13px.png')
}
}

0 comments on commit 8f7cd60

Please sign in to comment.