This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Update to GOV.UK Frontend v3 #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chao-xian
changed the title
injms
force-pushed
the
update-to-govuk-frontend-3-0
branch
2 times, most recently
from
8d71772 to
3501944
Compare
kr8n3r
reviewed
Sep 10, 2019
injms
force-pushed
the
update-to-govuk-frontend-3-0
branch
4 times, most recently
from
ec7e5bf to
82bcf7e
Compare
kr8n3r
reviewed
Sep 11, 2019
kr8n3r
reviewed
Sep 11, 2019
injms
force-pushed
the
update-to-govuk-frontend-3-0
branch
from
5fc75c3 to
6c89efc
Compare
injms
force-pushed
the
update-to-govuk-frontend-3-0
branch
5 times, most recently
from
ef8860f to
2a88401
Compare
- enable the compatibility modes for Frontend Toolkit and v2 of GOV.UK Frontend
- Homepage blue hero panel moved 1 pixel up to hide the phase banner's lower grey border - Hero panel bespoke CSS reduced and refactored - Search in hero panel now uses search component from GOV.UK Publishing Components - Line height on paragraph text increased to avoid focus state overlap
- Update the way full width works to not reply on `#id` selector - Refactor service standard and guide templates to use GOV.UK Frontend - Replace hardcoded heading and metadata markup with components from GOV.UK Publishing Components
- Remove duplicate test for feedback component, as the tests for this component are in GOV.UK Publishing Components - Turn off linting for ID selector for full width container override
- Subsections on topic template completely replaced with standard GOV.UK Frontend styles
- Replace bespoke CSS with GOV.UK Frontend styles - Tidy up negative margins
- Use accordion component from GOV.UK Frontend via GOV.UK Publishing Components - Add new helper function to take content and change it to hash shape required by accordion component - Introduce another helper function to check whether content should be displayed in an accordion - Tweak existing helper function to see whether accordion section should be expanded - Add inline documention to accordion presenter methods - Remove duplicated accordion tests; tests are upstream in GOV.UK Frontend - Slightly more consistent logic added - an accordion is only used on pages where there are more than two sections.
injms
force-pushed
the
update-to-govuk-frontend-3-0
branch
from
2a88401 to
45ef40e
Compare
injms
changed the title
|
there's some toolkit specific mixins left there. i guess the intention is to address that later? |
Yeah, that's right - we can remove toolkit later. I've replaced some mixins as I've come across them in this upgrade, so there's a mix of Frontend Toolkit and GOV.UK Frontend mixins in this pull request. |
kr8n3r
reviewed
Sep 17, 2019
|
there are some minor spacing differences but that's to be expected. |
kr8n3r
approved these changes
Sep 17, 2019
- Some spacing and layout tweaks to ensure that these changes are visually consistent with previous version - Remove CSS classes in markup that aren't needed
injms
force-pushed
the
update-to-govuk-frontend-3-0
branch
from
45ef40e to
fcbfa45
Compare
|
Thanks for your work on this @injms! |
alex-ju
added a commit
that referenced
this pull request
Feb 25, 2021
The need for this script was removed in #518 but we're still serving this asset to users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Service Manual to use the latest version of GOV.UK Publishing Components, which means version 3 🐝 of GOV.UK Frontend.
Lots of bespoke markup and CSS deleted and replaced with components:
Trello card: https://trello.com/c/zArhsTSW/56-3-update-service-manual-frontend-to-govukpublishingcomponents-v19-with-compatibility-mode-on
Quick checks (locally, as no preview app):