Skip to content

Commit

Permalink
Add rubocop-rake with all defaults
Browse files Browse the repository at this point in the history
This adds a few extra cops from the rubocop-rake, which is maintained
by rubocop-hq. All the defaults seem to be reasonable:

  - Rake/ClassDefinitionInTask - makes them harder to find
  - Rake/Desc - we mostly do this already
  - Rake/DuplicateNamespace
  - Rake/DuplicateTask
  - Rake/MethodDefinitionInTask - top-level methods are bad
  • Loading branch information
Ben Thorner committed Mar 30, 2020
1 parent a988ac7 commit a3afe0a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ inherit_from:
- other-style.yml
- other-metrics.yml
- other-excludes.yml
- rake.yml
1 change: 1 addition & 0 deletions config/rake.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
require: rubocop-rake
1 change: 1 addition & 0 deletions rubocop-govuk.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ Gem::Specification.new do |spec|

spec.add_dependency "rubocop", "0.80.1"
spec.add_dependency "rubocop-rails", "~> 2"
spec.add_dependency "rubocop-rake", "~> 0.5.1"
spec.add_dependency "rubocop-rspec", "~> 1.28"
end

0 comments on commit a3afe0a

Please sign in to comment.