This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Install to Python virtualenv #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm 99% sure that a `subscribe` has no effect on a file. You can't notify a file resource to be evaluated - they are always evaluated. The chaining in `init.pp` ensures that `::install` always happens before `::config`.
Install Graphite, Carbon, Whisper, and (nearly) all dependencies into a virtualenv using the `stankevich/python` module. This retains the same sandboxing that `--install-option`/`--prefix` was doing, but with the added benefit of: - Allowing the version param to upgrade and downgrade the packages without writing the `pip` logic ourselves. - Isolating dependencies from the system's Python/pip paths. Absolute binary paths are used to reference the virtualenv without needing to `source bin/activate` each time. Cairo is shimmed into the virtualenv from the system package because of the reasons described in the class doc. I've rebased the dependencies against Graphite's `requirements.txt` to reference specific versions and dropped: - LDAP support: because it has compile dependencies and I'm not aware of anyone currently using this functionality from the module. - pysqlite2: because Python >=2.6 has this builtin. I'm using an earlier version of the `python` module because of the following bug which causes the virtualenv to be recreated on every run: - voxpupuli/puppet-python#46 Tests will be committed separately because they depend on refactoring currently in unmerged PR #16.
Caused by and workaround taken from: - graphite-project/carbon#86
New fixture. Changed paths. No longer testing every package in `::deps`, since it's a bit pointless.
Use binary from virtualenv to load correct search paths.
|
Rebased against #16 |
rjw1
added a commit
that referenced
this pull request
Jan 3, 2014
…egator Install to Python virtualenv
| 'python-pysqlite2', | ||
| 'python-support', | ||
| 'python-pip', | ||
| python::virtualenv { $root_dir: } -> |
There was a problem hiding this comment.
who's responsible for actually creating the $root_dir directory?
There was a problem hiding this comment.
turns out it's python::virtualenv, but stankevich/python 1.6.0 had a bug which caused this to fail (fixed by stankevich/python@e6b4b941713, in 1.6.1)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install Graphite, Carbon, Whisper, and (nearly) all dependencies into a
virtualenv using the
stankevich/pythonmodule. This retains the samesandboxing that
--install-option/--prefixwas doing, but with the addedbenefit of:
writing the
piplogic ourselves.Absolute binary paths are used to reference the virtualenv without needing
to
source bin/activateeach time. Cairo is shimmed into the virtualenvfrom the system package because of the reasons described in the class doc.
I've rebased the dependencies against Graphite's
requirements.txttoreference specific versions and dropped:
anyone currently using this functionality from the module.
I'm using an earlier version of the
pythonmodule because of the followingbug which causes the virtualenv to be recreated on every run:
/cc @rjw1 @KushalP @philandstuff