Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Initial stab at CONTRIBUTING.md for puppet module #12

Merged
merged 2 commits into from
Dec 17, 2013
Merged

Conversation

philandstuff
Copy link
Contributor

Basing this off of alphagov/business-support-finder#46 by @mnowster

I explicitly haven't linked to our puppet style guide as that's got a
lot of stuff that's not relevant for modules (nagios, upstart etc).

Basing this off of alphagov/business-support-finder#46 by @mnowster

I explicitly haven't linked to our puppet style guide as that's got a
lot of stuff that's not relevant for modules (nagios, upstart etc).

Write tests using [rspec-puppet](http://rspec-puppet.com/).

Ensure that you run `rake spec` and `rake lint` so that the tests pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And rake syntax? Maybe just rake, if the default task is set correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rake syntax doesn't do anything in this repo. Maybe we should update the rakefile to match our other rakefiles.

@dcarley
Copy link
Contributor

dcarley commented Dec 16, 2013

Nice. We should get this into gds-operations/puppet-module-skeleton too

@philandstuff
Copy link
Contributor Author

good plan, @dcarley. I thought I'd spike it out in a particular repo before introducing it generally, and this one has had most public PRs.

dcarley added a commit that referenced this pull request Dec 17, 2013
Initial stab at CONTRIBUTING.md for puppet module
@dcarley dcarley merged commit 8e10821 into master Dec 17, 2013
@dcarley dcarley deleted the contributing branch December 17, 2013 11:47
philandstuff added a commit to gds-operations/puppet-module-skeleton that referenced this pull request Jan 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants