PP-7570 Fix logging context for POST requests #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue when body-parser middleware is added after an AsyncLocalStorage store is opened, where the async context is lost. This is identified here https://stackoverflow.com/questions/64330910/nodejs-asynclocalstorage-getstore-return-undefined , although no cause is identified. This ordering was also required in Toolbox when using a different library using async_hooks. Change middleware ordering to fix this.
sfount
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Similar behaviour observed in Toolbox but not much context from the time alphagov/pay-toolbox@fc22472
Potentially we can submit an issue questioning the behaviour to have someone who knows the details of the urlencoded() body parser comment, it may be something we can pitch in to help fix upstream in express.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when body-parser middleware is added after an AsyncLocalStorage store is opened, where the async context is lost.
This is caused by a downstream dependency oh Express's POST body parser middleware as identified expressjs/body-parser#404.
More detail can be found https://nodejs.org/api/async_hooks.html#async_hooks_troubleshooting.
This ordering was also required in Toolbox when using a different library using async_hooks.
Change middleware ordering to fix this.