PP-11548: Initialise prom metrics without default sample builder #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlsteers
reviewed
Sep 19, 2023
| @@ -71,8 +70,11 @@ public DataSourceFactory getDataSourceFactory(LedgerConfig configuration) { | |||
|
|
|||
| @Override | |||
| public void run(LedgerConfig config, Environment environment) { | |||
| config.getEcsContainerMetadataUriV4().ifPresent(uri -> initialisePrometheusMetrics(environment, uri)); | |||
|
|
|||
| LOGGER.info("Initialising prometheus metrics."); | |||
There was a problem hiding this comment.
how useful is this log line?
There was a problem hiding this comment.
Not, good call, removed
nlsteers
previously approved these changes
Sep 19, 2023
|
@nlsteers I've removed the log line, would you mind reapproving |
nlsteers
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now we don't need to build our default labels in the app (since they are now added by the sidecar) we should remove the default sample builder.
How?
This change has already been rolled out to connector and is working well.