Skip to content

Commit

Permalink
Add Exemption object to Ledger Specification
Browse files Browse the repository at this point in the history
With this commit, we are starting to introduce the exemption object in the
Ledger specification so that it will be added to the TransactionView.

If an exemption was requested, the new object will be set with the property
`requested` set to true. If we know that an exemption was not requested, then
the new object will be set with the property `requested` set to false.

Further information in the JIRA ticket below.

https://payments-platform.atlassian.net/browse/PP-13332
  • Loading branch information
marcotranchino committed Nov 21, 2024
1 parent 68b6e04 commit e792ff2
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
10 changes: 7 additions & 3 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@
{
"path": "detect_secrets.filters.allowlist.is_line_allowlisted"
},
{
"path": "detect_secrets.filters.common.is_baseline_file",
"filename": ".secrets.baseline"
},
{
"path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
"min_level": 2
Expand Down Expand Up @@ -121,14 +125,14 @@
"filename": "openapi/ledger_spec.yaml",
"hashed_secret": "9baeb3f7db14ddab5d172149762035c0c022d76d",
"is_verified": false,
"line_number": 1644
"line_number": 1652
},
{
"type": "Hex High Entropy String",
"filename": "openapi/ledger_spec.yaml",
"hashed_secret": "920734ed7628ef47739eed5571412e2c8271790f",
"is_verified": false,
"line_number": 1718
"line_number": 1728
}
],
"src/main/java/uk/gov/pay/ledger/event/model/Event.java": [
Expand Down Expand Up @@ -159,5 +163,5 @@
}
]
},
"generated_at": "2024-07-22T11:29:46Z"
"generated_at": "2024-11-21T09:40:02Z"
}
10 changes: 10 additions & 0 deletions openapi/ledger_spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1335,6 +1335,14 @@ components:
wallet_type:
type: string
example: APPLE_PAY
Exemption:
type: object
properties:
requested:
type: boolean
description: It is set when the exemption has been requested or when we know that it has not been requested.
example: true
nullable: false
ExternalTransactionState:
type: object
properties:
Expand Down Expand Up @@ -1655,6 +1663,8 @@ components:
evidence_due_date:
type: string
format: date-time
exemption:
$ref: '#/components/schemas/Exemption'
fee:
type: integer
format: int64
Expand Down

0 comments on commit e792ff2

Please sign in to comment.